-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPTS objects as data.frame #568
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue summarizes the outcomes of a discussion of May 16, 2023.
Goal
Get rid of the bioRad objects
vp
andvpts
. Instead, make them VPTS data frames, so they can are compatible with functions outside bioRad, likedplyr
.Design decisions
vpts
:print(vpts)
shows summary information and the default tibble preview. The summary information is for the whole data frame, not per radar. Users can reduce that info by runningfilter(radar == "bejab")
beforehand:filter(radar == "radar")
on the dataframe.plot.vp()
) can be integrated in vpts functions, but return something specific (e.g. this plot) if it only contains a single radar/timestamp. Alternatively, those VPTS objects could have an additional class property:$radar
,$datetime
,$attributes
) could added as attributes, so they are available to the user for inspection. The moment the VPTS object contains multiple radars/timestamps, those attributes would be discarded.check_vpts()
function could be added to see if a VPTS object meets criteria (e.g. expect col names and col types).dplyr
functions, so they don't create invalid VPTS objects. See https://dplyr.tidyverse.org/reference/dplyr_extending.htmlregularize_vpts()
function could be expended, so it allows to:vp
,c(vp)
orvpts
as input should be adapted to work with VPTS data frames.The text was updated successfully, but these errors were encountered: