Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Configuration Documentation: "client_secret" is "client_secrets" - adapt documentation #692

Open
pahupe opened this issue May 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pahupe
Copy link
Contributor

pahupe commented May 10, 2024

Expected Behavior

The documentation (OAuth configuration) matches the tool (version 4.2.0).

Actual Behavior

The documentation for OAuth does not match the config keys in 4.2.0:

The documentation at https://github.com/adobe/aio-cli-plugin-cloudmanager?tab=readme-ov-file#setup-for-oauth-integration mentions that the OAuth config has a key "client_secret", but the field is now called "client_secrets" (for OAuth only) and has become a list property, see e.g. here: https://github.com/adobe/aio-cli-plugin-cloudmanager/blob/main/e2e/e2e.js#L72

Reproduction Scenario, Platform, and Version

Version 4.2.0

Steps to Reproduce

Setup aio cli-cloudmanager using OAuth according to documentation https://github.com/adobe/aio-cli-plugin-cloudmanager?tab=readme-ov-file#setup-for-oauth-integration
You will get an HTTP 400 (parameter client_secrets missing)

@pahupe pahupe added the bug Something isn't working label May 10, 2024
@kwin
Copy link
Contributor

kwin commented May 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants