Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Properties dialog instrumented twice #2859

Open
HitmanInWis opened this issue Sep 20, 2024 · 0 comments
Open

Page Properties dialog instrumented twice #2859

HitmanInWis opened this issue Sep 20, 2024 · 0 comments

Comments

@HitmanInWis
Copy link

JavaScript executing on Page Properties instruments the dialog twice. I'm unsure why, but the dialog-loaded event seems to trigger twice on open of Page Properties, hence double-instrumenting.

This impacts the following:

  • Inherited fields (Brand Slug) - apps/core/wcm/components/page/v3/page/clientlibs/editor/js/brandSlugTuple.js
  • Page Image upload field - apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js

Perhaps we need a simple mechanism that marks a dialog as "instrumented" so that if dialog-loaded fires multiple times for the same dialog open we can exit quickly on instances after the first load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant