Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Components Page V2 Field Issue - Brand Slug Cannot Inherit Live Copy #2516

Open
charlie-yc-tsai opened this issue May 31, 2023 · 3 comments · May be fixed by #2854
Open

Core Components Page V2 Field Issue - Brand Slug Cannot Inherit Live Copy #2516

charlie-yc-tsai opened this issue May 31, 2023 · 3 comments · May be fixed by #2854

Comments

@charlie-yc-tsai
Copy link

Bug Report

page properties from core/wcm/components/page/v2 cannot inherit live copy
Field with problems : Basic Tab - Branding - Brand Slug

Environment

  • AEM 6.5.13.0
  • Core Components version 2.19.0
  • JRE version OpenJDK Runtime Environment(build 11.0.17+8-LTS)

Additional context / Screenshots
image

@juliaetate
Copy link

juliaetate commented Feb 5, 2024

Is there any info on this? We're seeing the brand slug get cleared in launches because the value isn't showing on the properties form, so when the properties are saved, it's being cleared and we're losing site branding every time a launch is promoted.

We've had to copy the brandSlugTuple.js from the Core Components clientlibs to the page clientlibs to get this field to populate in Launches and on the page properties page.

@paulochang
Copy link

This is caused by a race condition on the brandSlugTuple.js
when

var checkboxFoundation = $brandSlugCheckbox.adaptTo("foundation-field");

is run... the checkbox still hasn't been initialized.. so the adapt returns an undefined object.

then, changeTextFieldState is called with enabled = false...

which means... this gets run..

            textfield.setDisabled(true);
            textfield.setValue(inheritedValue || "");

setting the textfield disabled and empty

@kmatterne
Copy link

Provided a fix for this in a Pull Request, for the issue that @paulochang mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants