You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spring Boot 3.3.4 upgrades Jetty to 12.0.13, which unfortunately breaks the test with AWS CRT-based S3 client (CrtAsyncV2IT.testStreamUploadOfUnknownSize and testStreamUploadOfUnknownSize_transferManager). The reason is probably the changed behaviour when handling 100-continue requests.
With Tomcat, the CRT client works fine. In 2018, Tomcat has been replaced with Jetty. The changelog does not include the reason why the server engine has been switched.
I've created a pull request which uses Tomcat (again) instead of Jetty.
The text was updated successfully, but these errors were encountered:
I am also not too happy with Jetty being used as the application container in S3Mock since Tomcat has been the default container for Spring Boot for many years, and the Jetty team is always behind on Servlet spec implementation, changed their interpretation of URIs in patch or minor versions, needing me to find those issues and fix S3Mock again and again, etc. I missed the opportunity to slip this change in when going from 2.x to 3.x (back then, I mainly updated Spring Boot from 2 to 3 and Java from 11 to 17).
Unfortunately, many people still depend directly on the Java release of S3Mock for their tests.
This changes the (transitive) dependencies and may break their builds. :(
If we merge this, the major version would need to be updated to 4.0.0.
I'm running into a similar issue and the update to Tomcat appears to fix it for me. @afranken any approximate idea on when you might be able to get this fix merged in given the need for a major version bump?
Spring Boot 3.3.4 upgrades Jetty to 12.0.13, which unfortunately breaks the test with AWS CRT-based S3 client (CrtAsyncV2IT.testStreamUploadOfUnknownSize and testStreamUploadOfUnknownSize_transferManager). The reason is probably the changed behaviour when handling 100-continue requests.
With Tomcat, the CRT client works fine. In 2018, Tomcat has been replaced with Jetty. The changelog does not include the reason why the server engine has been switched.
I've created a pull request which uses Tomcat (again) instead of Jetty.
The text was updated successfully, but these errors were encountered: