Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Disable sorting of wildcards before processing" should be the default. #715

Open
schwern opened this issue Jan 23, 2024 · 0 comments · May be fixed by #716
Open

"Disable sorting of wildcards before processing" should be the default. #715

schwern opened this issue Jan 23, 2024 · 0 comments · May be fixed by #716

Comments

@schwern
Copy link

schwern commented Jan 23, 2024

Problem

By default, cyclical options in prompts and cyclical options in wildcards behave differently. ${number={@3|2|4}} will produce 3, 2, 4, 3, ... but in a wildcard file it will always sort them: 2, 3, 4, 2, ... This behavior is surprising and makes refactoring prompts into wildcard files difficult and confusing.

I spent quite some time trying to debug the problem and even wrote up a whole bug report before I found the "Disable sorting of wildcards before processing" option by searching the code.

Solution

"Disable sorting of wildcards before processing" should be on by default so options cycling behaves the same whether they're in a prompt or a wildcard file. This makes creating wildcard files easier.

Alternatively, document "Disable sorting of wildcards before processing"

schwern added a commit to schwern/sd-dynamic-prompts that referenced this issue Jan 23, 2024
@schwern schwern linked a pull request Jan 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant