-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save an Activity Report #102
Conversation
Grants/grantees are already seeded, changing participants to just be nonGrantees
This reverts commit fddb56b.
…TTADP into sj-activity-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and everything performs as advertised. Code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting to see this! Great job! 👍
name: { | ||
type: DataTypes.VIRTUAL, | ||
get() { | ||
return `${this.grantee.name} - ${this.number}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
}; | ||
|
||
const reportObject = { | ||
participantType: 'gratnee', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
@jasalisbury is the author of this PR
Description of change
Add the ability to save, retrieve and update an Activity Report. Also provides an endpoint the frontend will need to complete an Activity Report (
activity-report/participants
). Activity Reports use the Activity Participants table to join to many grants or non-grantees. This PR only contains backend changes. Frontend changes are coming in a separate PR.ActivityReports
,ActivityParticipants
andNonGrantees
lib
folder so controllers don't have to directly talk to the database layer{grantee.name} - {grant.number}
available as a columnJest tests are run in parallel by default. This was causing issues for tests that hit the database, as one test would remove items a different test relied on. We are now passing the
--runInBand
flag to jest so tests run sequentially. After the MVP we may want to look at allowing tests to run in parallel again.How to test
Note the ID returned (will probably be 1)
Issue(s)
Checklist