-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form validations to all create flows #841
Comments
I've been doing some digging during work today and I might be able to get this done if you haven't resolved this in any way yet. |
Would be happy to get the help, @amilliiee! Will assign you now, and let me know if there's anything I can do to help 😊 |
I think right now the only question I have is how we want this organized. I'm assuming a single validation file? |
Would be great, @amilliiee 😊 Thanks for checking in! |
Hey @amilliiee 👋 Looping @to-sta into this discussion as he's working on the login for the backend and we should have shared processes :) Let us know if you're definitely going with formkit and what the plans are 😊 Feedback from both of us is that formkit sounds good! |
@andrewtavis @to-sta I just figured since it can handle validation on it's own, it would cut down on what we'd need to do to get it working :)
Edit: |
Hey @amilliiee 👋 Sorry for not checking this sooner :) Was gone for a week, and lots to do at work once I was back. Will check this over the weekend, and also feel free to drop into the dev sync tomorrow where we can discuss this as a group 😊 CC @momanyisamuel, this is the issue that's looking at form validation :) |
Hey @amilliiee 👋 We're trying to check the sandbox within the dev sync now, but then we're getting something went wrong... Would you be able to open a PR with the changes? :) |
Terms
Description
Something that's needed is for all create flows to have form validations such that submission is not possible without certain fields being filled. The following flows need validation:
organizations/create
groups/create
Contribution
I'll likely work on this myself, but someone else could also do this so long as they understand that it needs to be done by the end of the weekend :)
The text was updated successfully, but these errors were encountered: