Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Foreign Key Lookup Transform doesn't set the field to nil if resolver fails #133

Open
colinux opened this issue Jul 23, 2013 · 1 comment

Comments

@colinux
Copy link

colinux commented Jul 23, 2013

Hello,

If a resolver fails, a ResolverError is raised (in foreign_key_lookup_transform.rb#L47).
This exception is catched in engine.rb#L385, but nil has not been set to the field (row[name] has not been updated line 382 because of the exception).

Is this the excepted behavior and the doc is wrong or is it a bug? (and I probably could propose a PR)

Thanks!

@thbar
Copy link
Member

thbar commented Jul 23, 2013

Hi!

I need to verify what's the historically expected behaviour on existing project - will let you know!

-- Thibaut

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants