Skip to content

Commit

Permalink
Merge pull request #2496 from aeisenberg/patch-2
Browse files Browse the repository at this point in the history
Update eslint.yml
  • Loading branch information
cannist authored Sep 12, 2024
2 parents 9db23a2 + dea60ba commit 8190cec
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
16 changes: 8 additions & 8 deletions code-scanning/appknox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
#
# Instructions:
#
# 1. In your repository settings, navigate to 'Secrets' and click on 'New repository secret.' Name the
# secret APPKNOX_ACCESS_TOKEN and paste your appknox user token into the value field. If you don't have a appknox token
# or need to generate a new one for GitHub, visit the Appknox Platform, go to Account Settings->Developer Settings
# 1. In your repository settings, navigate to 'Secrets' and click on 'New repository secret.' Name the
# secret APPKNOX_ACCESS_TOKEN and paste your appknox user token into the value field. If you don't have a appknox token
# or need to generate a new one for GitHub, visit the Appknox Platform, go to Account Settings->Developer Settings
# and create a token labeled GitHub
#
# 2. Refer to the detailed workflow below, make any required adjustments, and then save it to your repository. After the
# 2. Refer to the detailed workflow below, make any required adjustments, and then save it to your repository. After the
# action executes, check the 'Security' tab for results

name: Appknox
Expand All @@ -25,7 +25,7 @@ on:
push:
branches: [ $default-branch, $protected-branches ]
pull_request:
branches: [ $default-branch ]
branches: [ $default-branch ]
jobs:
appknox:
runs-on: ubuntu-latest
Expand All @@ -37,18 +37,18 @@ jobs:
java-version: 1.8
- name: Grant execute permission for gradlew
run: chmod +x gradlew

- name: Build the app
run: ./gradlew build # Update this to build your Android or iOS application

- name: Appknox GitHub action
uses: appknox/appknox-github-action@b7d2bfb2321d5544e97bffcba48557234ab953a4
with:
appknox_access_token: ${{ secrets.APPKNOX_ACCESS_TOKEN }}
file_path: app/build/outputs/apk/debug/app-debug.apk # Specify the path to your .ipa or .apk here
risk_threshold: MEDIUM # Update this to desired risk threshold [LOW, MEDIUM, HIGH, CRITICAL]
sarif: Enable

- name: Upload SARIF to GHAS
if: always()
uses: github/codeql-action/upload-sarif@v3
Expand Down
6 changes: 4 additions & 2 deletions code-scanning/eslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ jobs:
- name: Install ESLint
run: |
npm install [email protected]
npm install @microsoft/eslint-formatter-sarif@2.1.7
npm install @microsoft/eslint-formatter-sarif@3.1.0
- name: Run ESLint
env:
SARIF_ESLINT_IGNORE_SUPPRESSED: "true"
run: npx eslint .
--config .eslintrc.js
--ext .js,.jsx,.ts,.tsx
Expand All @@ -47,4 +49,4 @@ jobs:
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: eslint-results.sarif
wait-for-processing: true
wait-for-processing: true

1 comment on commit 8190cec

@xunlongDav
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4269

Please sign in to comment.