Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lts alias for lts/* #996

Open
zdm opened this issue Apr 3, 2024 · 9 comments
Open

Add lts alias for lts/* #996

zdm opened this issue Apr 3, 2024 · 9 comments
Labels
feature request New feature or request to improve the current logic

Comments

@zdm
Copy link

zdm commented Apr 3, 2024

Description:
Could you please add simple lts alias for the latest lts version in addition to the lts/*?
lts/* is not obvious, ugly and confusing.

If ypu don't want to do this - please, close this issue immediately,

@zdm zdm added feature request New feature or request to improve the current logic needs triage labels Apr 3, 2024
@HarithaVattikuti
Copy link
Contributor

Hello @zdm
Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

@ThePlenkov
Copy link

oh wow! That's exactly how I reached here. So following the official doc page:

- uses: actions/setup-node@v4
  with:
    # Version Spec of the version to use in SemVer notation.
    # It also admits such aliases as lts, latest, nightly and canary builds
    # Examples: 12.x, 10.15.1, >=10.15.0, lts/Hydrogen, 16-nightly, latest, node
    node-version: ''

we can see It also admits such aliases as lts

but this is what we get in real:

Run actions/setup-node@v4
  with:
    node-version: lts
    registry-url: https://registry.npmjs.org/
    always-auth: false
    check-latest: false
    token: ***
Attempting to download lts...
Not found in manifest. Falling back to download directly from Node

@voldemortensen
Copy link

@ThePlenkov's experience is exactly how I ended up here as well. An lts alias would be great, but at a minimum the docs should be updated to be more clear.

@GauthierPLM
Copy link

Same feedback: the lts alias is described in the doc but doesn't work.

@zdm
Copy link
Author

zdm commented Sep 18, 2024

Is it possible to fix it? It will bee pretty easy to rename incoming tls option to lts/*.

yomatters added a commit to access-ci-org/xras-ui that referenced this issue Sep 18, 2024
@zdm
Copy link
Author

zdm commented Oct 23, 2024

@HarithaVattikuti
Could you, please, make lts works?
This is really 5-minutes fix.
Just need to translate command line option 'ltstolts/*``.
Thank you.

@zdm
Copy link
Author

zdm commented Oct 23, 2024

I can create PR, this is not a problem, but my experience says, that 99% of PRs from third-party developers are rejected.

@ThePlenkov
Copy link

@zdm if you know where to add - could you please create this PR and link to this issue? Thanks!

@zdm
Copy link
Author

zdm commented Nov 5, 2024

let's merge my PR and forget about this problem, it is already took too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

5 participants