From 3e2f891890af4be499821c8db56e1d14d5bb8508 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 28 Aug 2022 15:47:55 +0200 Subject: [PATCH] fix review issues --- __tests__/installer.test.ts | 4 ++-- action.yml | 4 ++-- docs/advanced-usage.md | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/__tests__/installer.test.ts b/__tests__/installer.test.ts index 755ee03d3..351069665 100644 --- a/__tests__/installer.test.ts +++ b/__tests__/installer.test.ts @@ -385,10 +385,10 @@ describe('setup-node', () => { os.platform = 'linux'; os.arch = 'x64'; - inputs['node-version'] = '12'; + inputs['node-version'] = '16'; inputs['corepack'] = 'true'; - const toolPath = path.normalize('/cache/node/12.16.1/x64'); + const toolPath = path.normalize('/cache/node/16.17.0/x64'); findSpy.mockReturnValue(toolPath); await main.run(); diff --git a/action.yml b/action.yml index bc976bc53..c703307db 100644 --- a/action.yml +++ b/action.yml @@ -15,7 +15,7 @@ inputs: description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.' default: 'false' corepack: - description: 'Set this option if you want to install the core-pack.' + description: 'Automatically enables corepack' default: 'false' registry-url: description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.' @@ -28,7 +28,7 @@ inputs: description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.' cache-dependency-path: description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.' -# TODO: add input to control forcing to pull from cloud or dist. +# TODO: add input to control forcing to pull from cloud or dist. # escape valve for someone having issues or needing the absolute latest which isn't cached yet outputs: cache-hit: diff --git a/docs/advanced-usage.md b/docs/advanced-usage.md index ef3812186..69cd4938a 100644 --- a/docs/advanced-usage.md +++ b/docs/advanced-usage.md @@ -301,7 +301,7 @@ steps: - uses: actions/setup-node@v3 with: node-version: '14.x' - corepack: enable + corepack: true ``` It is recommended to configure `package.json#packageManager` if you want to use it. @@ -310,7 +310,7 @@ e.g. ```json { "name": "example", - "packageManager": "pnpm@7.5.2", + "packageManager": "pnpm@7.9.5", // ... } ```