Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically auth package source mapping that match source-url #543

Open
CoenraadS opened this issue Aug 15, 2024 · 3 comments
Open

Automatically auth package source mapping that match source-url #543

CoenraadS opened this issue Aug 15, 2024 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@CoenraadS
Copy link

CoenraadS commented Aug 15, 2024

Description:
When NuGet.Config contains a package source that matches source-url, automatically auth that source correctly.

Justification:
Currently a user may have the following step in their Action:

- uses: actions/setup-dotnet@v4
  with:
    dotnet-version: 8.x.x
    source-url: https://nuget.pkg.github.com/example/index.json
  env:
    NUGET_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}

And a NuGet.Config with the following:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
    <add key="github" value="https://nuget.pkg.github.com/example/index.json" />
  </packageSources>
<packageSourceMapping>
    <packageSource key="nuget.org">
      <package pattern="*" />
    </packageSource>
    <packageSource key="github">
      <package pattern="Example.*" />
    </packageSource>
  </packageSourceMapping>
</configuration>

Nuget restore will fail with authorization errors, which is unexpected since they provided a source-url and NUGET_AUTH_TOKEN.

They have to manually auth the mapping:

- name: dotnet
  run: dotnet ...
  env:
    NuGetPackageSourceCredentials_github: Username=${{ github.actor }};Password=${{ secrets.GITHUB_TOKEN }}

The setup-dotnet should automatically fixup the auth for mappings that match the provided source-url

@CoenraadS CoenraadS added feature request New feature or request to improve the current logic needs triage labels Aug 15, 2024
@CoenraadS CoenraadS changed the title Automatically detect package source mapping Automatically auth package source mapping that match source-url Aug 15, 2024
@priyagupta108
Copy link

Hi @CoenraadS 👋,
Thank you for the feature request. We'll investigate it and come back to you with the details!

@KarolStosik
Copy link

@priyagupta108 Is it any ETA for this issue? Another way to solve this, may be to add support for configuration of Package Source Mapping using dedicated action parameter.

@KarolStosik
Copy link

KarolStosik commented Nov 15, 2024

@CoenraadS @priyagupta108 I've verified this, and it looks like this is already implemented 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants
@CoenraadS @KarolStosik @priyagupta108 and others