Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0-alpha.1 #575

Closed
MaksimZhukov opened this issue May 24, 2023 · 15 comments
Closed

v5.0.0-alpha.1 #575

MaksimZhukov opened this issue May 24, 2023 · 15 comments

Comments

@MaksimZhukov
Copy link
Contributor

We released the new alpha version of the action. It introduces the following major changes:

  1. Fix the bug related to the sync-labels input. Now the input value is read correctly.
  2. Add the ability to apply labels based on base and/or head branch names.
  3. Change the behavior of the any selector to match ANY file against ANY glob pattern.

For more information, see the release notes.

This is an alpha release and we would like to ask you to try it out and provide us with your feedback. If you have any questions, ideas or concerns, please share them in this issue.
Thank you!

@kachkaev
Copy link
Contributor

kachkaev commented Jun 5, 2023

How about setting dot option to true by default? I can craft a PR if this change is desired. From my personal experience, ‘special treatment’ of dot files by labeler is somewhat surprising. I guess that the vast majority of developers would want to set dot: true anyway.

@MaksimZhukov
Copy link
Contributor Author

@kachkaev Thanks for the suggested idea! We will consider adding it to the new major release.

@lucacome
Copy link

@MaksimZhukov I've been using the alpha for the past moth in multiple repos and everything works as expected.
Any chance we can get a new alpha/beta with all the new features/updates that went into main? 🙏

@MaksimZhukov
Copy link
Contributor Author

Thank you @lucacome for the feedback, we really appreciate it!
We are considering the possibility of expanding the functionality of the alpha version. As soon as we finish the investigation, we will make appropriate changes, if necessary, and release a stable version.
Thank you for your patience!

@jorgepiloto
Copy link

Hi @MaksimZhukov, I can confirm it fixes the issues with the sync-labels. The fact that this version adds labels based on branch names, is an excellent feature. Thanks for all the effort and time you devoted to this action ❤️

@MaksimZhukov
Copy link
Contributor Author

MaksimZhukov commented Sep 20, 2023

Hello everyone!
We've released a new beta version of the action. The configuration file structure was changed to provide more flexibility for changed-files. For more information, see the release notes and this issue.

If you have any questions, ideas or concerns, please share them in this issue.

@dfandrich
Copy link
Contributor

There seems to be a different bug with sync-labels now. When not explicitly setting sync-labels in the GHA job file, the job errors out with

TypeError: Input does not meet YAML 1.2 "Core Schema" specification: sync-labels Support boolean input list: `true | True | TRUE | false | False | FALSE`

There needs to be an explicit sync-labels: false in the workflow file to avoid this; it can't be left out to rely on the default false value.

@MaksimZhukov
Copy link
Contributor Author

@dfandrich, thank you for reporting this! Could you please create a new issue?

@joshdales
Copy link
Contributor

Thanks for the updates in the new beta version - I was wondering why not use consistent casing for all the config keys names? eg. the new changed-files nested keys are all in PascalCase now rather than kebab-case. Would it not be better to have them all be the same?

I realise that some of this might be my fault as I added some of those keys 😅 I personally don't have a preference, I just went with kebab-case initially because it was the same as the action config, but if the nested changed file options are how y'all would rather future keys are then might make sense to switch changed-files, head-branch, base-branch as well?

@MaksimZhukov
Copy link
Contributor Author

@joshdales, this is a great point, thank you. We will switch the nested options to kebab-case

@cwire4
Copy link

cwire4 commented Oct 3, 2023

Have the outputs changed or gone away in the beta? I originally used version 4 of the action and grabbed a snippet that outputs the new-labels and all-labels for the run. When I switched to the beta version, this step no longer outputs any labels even if some were added.

This is the step I have in my yaml:

  • name: "Check Outputs"
    run: |
    echo 'New labels:'
    echo '${{ steps.labeler.outputs.new-labels }}'
    echo '-------------------------'
    echo 'All labels:'
    echo '${{ steps.labeler.outputs.all-labels }}'

The previous step's id is still labeler.

@dfandrich
Copy link
Contributor

dfandrich commented Oct 3, 2023 via email

@onesneakymofo
Copy link

onesneakymofo commented Nov 3, 2023

Is there anyway someone can squeeze #688 in to the v5 release please? We title our PRs with [FEATURE], [BUG], [CHORE], etc. and it would be nice to auto-label based off of that so we can automate our release notes. 🙏

@OJFord
Copy link

OJFord commented Nov 22, 2023

@MaksimZhukov May I second that dot: true by default would be good - afaict the only reason to add it default false was to avoid it being a breaking change, so why not break now with the v5?

I can't think of any reason someone would want not to match dotfiles on path specs that do match them, it's not as if it's something weird & controversial like an 'implied dot' where '^foobar$' matches both 'foobar' and '.foobar'. It's just a random gotcha.

@MaksimZhukov
Copy link
Contributor Author

Hello everyone!
We have released the new major version of the action. In the new version, dot input is set to true by default. It also contains a bunch of other important changes. Please read the action documentation to find out how to adapt your configuration files and workflows for use with the new action version.

Thank you all for your feedback and patience! We really appreciate this!
Do not hesitate to contact us if you have any questions!

@MaksimZhukov MaksimZhukov unpinned this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants