Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 should not be broken forever! #15

Closed
CAMOBAP opened this issue Jun 8, 2024 · 4 comments
Closed

v1 should not be broken forever! #15

CAMOBAP opened this issue Jun 8, 2024 · 4 comments
Assignees

Comments

@CAMOBAP
Copy link
Collaborator

CAMOBAP commented Jun 8, 2024

After discussion metanorma/coradoc#101 (comment)

We agreed to fix v1 to support both old an new metanorma based on version check

@CAMOBAP CAMOBAP self-assigned this Jun 8, 2024
CAMOBAP added a commit to actions-mn/site-gen that referenced this issue Jun 9, 2024
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jun 9, 2024

site-gen action fixed for v1 so build-and-publish@v1 which rely on site-gen@v1 should be fixed too

cc @ronaldtse

@CAMOBAP CAMOBAP closed this as completed Jun 9, 2024
@ronaldtse
Copy link

Thank you @CAMOBAP !!

@ronaldtse
Copy link

@CAMOBAP does that mean we now have the ability to choose Metanorma versions to run via GHA? Like how Ruby versions work?

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jun 10, 2024

@CAMOBAP does that mean we now have the ability to choose Metanorma versions to run via GHA? Like how Ruby versions work?

To be on the same page in GHA we have two ways to setup version of metanorma:

  1. In a container i.e.
    ...
    runs-on: ubuntu-latest
    container:
      image: metanorma/metanorma:x.y.z
    ...
    
  2. in our actions-mn/setup
    ...
    steps:
      - uses: actions/checkout@v4
      - uses: actions-mn/setup@v1
         with:
           version: x.y.z
    

Those ones was there long time before and we use the for some our abandoned flavors already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants