Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast rules [afw4f7, 09o5cg]: clarify behaviour on submit buttons #2204

Open
Jym77 opened this issue Jul 22, 2024 · 1 comment
Open

Comments

@Jym77
Copy link
Collaborator

Jym77 commented Jul 22, 2024

Text has minimum contrast and Text has enhanced contrast are targeted at text nodes.

Some text appear as text on the page without being in a DOM text node, typically in a Submit button: <input type="submit" value="Next" /> has a text of Next and <input type="submit" /> has a text of (localised) Submit. The rules currently ignore these.

I'm not sure we should force the rules to look at these (they are complex enough, separate rules might be better at handling this). I think we should add an Inapplicable example to make the behaviour explicit.
(🤔 actually it might be better suited as a verbose example since it would be better as "inapplicable but bad" but then it would fail the requirements…)

@Jym77
Copy link
Collaborator Author

Jym77 commented Jul 25, 2024

CG decision: we should try and come up with a definition of "text" to capture both, that way we can extend it later (select, …)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants