Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update to TypeScript v4.5.x due to zerollup issue #194

Closed
j-d-carmichael opened this issue Feb 5, 2022 · 4 comments
Closed

Cannot update to TypeScript v4.5.x due to zerollup issue #194

j-d-carmichael opened this issue Feb 5, 2022 · 4 comments
Labels
Blocked Issue Issue blocked by 3rd party

Comments

@j-d-carmichael
Copy link
Contributor

j-d-carmichael commented Feb 5, 2022

4.5.x results in a ts build error:

TypeError: Cannot read property 'impliedNodeFormat' of undefined

The issue is narrowed down to this:
zerkalica/zerollup#37

There is a PR on it, but it is not being merged in by the maintainer:
zerkalica/zerollup#38

The PR didn't appear to work after a few attempts of tsconfig and package json configs.

The package.json has pegged ts to ~4.3.5 for now until the fix is out

@p-mcgowan
Copy link
Contributor

p-mcgowan commented Feb 5, 2022

zerkalica/zerollup#37 (comment) resolves it by just patching ts-transform-paths after install.

short term fix until the merge goes in - wouldnt suggest bringing it into main trunk, but should unblock the update.

the PR is a month old, doesn't seem like it's moving along too quick.

@j-d-carmichael j-d-carmichael changed the title Cannot update to ts 4.5.x due to zerollup Cannot update to TypeScript v4.5.x due to zerollup issue Feb 5, 2022
@j-d-carmichael j-d-carmichael added the Blocked Issue Issue blocked by 3rd party label Feb 7, 2022
@j-d-carmichael
Copy link
Contributor Author

Someone has published a new version on npm containing the fix: zerkalica/zerollup#38

If the author doesn't accept this PR we might want to consider switching to this or replacing zerollup with an alternative path resolver

@p-mcgowan
Copy link
Contributor

would definitely just look into ts-config-paths more heavily. seems like a solid option and has a lot of usage, very common in other projects.

@j-d-carmichael
Copy link
Contributor Author

this has been resolved a long time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issue Issue blocked by 3rd party
Projects
None yet
Development

No branches or pull requests

2 participants