wallet: Check specified wallet exists before migration

achow101 · achow101 · commit f42ec0f3bfbe · 2024-11-12T21:19:27.000-05:00
The previous error message for non-existent wallets of "Already a
descriptor wallet" is misleading. Return a more specific error when a
non-existent wallet is specified.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -4407,6 +4407,9 @@ util::Result<MigrationResult> MigrateLegacyToDescriptor(const std::string& walle
         if (!wallet_path) {
             return util::Error{util::ErrorString(wallet_path)};
         }
+        if (!fs::exists(*wallet_path)) {
+            return util::Error{_("Error: Wallet does not exist")};
+        }
         if (!IsBDBFile(BDBDataFile(*wallet_path))) {
             return util::Error{_("Error: This wallet is already a descriptor wallet")};
         }

Original file line number	Diff line number	Diff line change
`@@ -4407,6 +4407,9 @@ util::Result<MigrationResult> MigrateLegacyToDescriptor(const std::string& walle`
`4407`	`4407`	`if (!wallet_path) {`
`4408`	`4408`	`return util::Error{util::ErrorString(wallet_path)};`
`4409`	`4409`	`}`
	`4410`	`+ if (!fs::exists(*wallet_path)) {`
	`4411`	`+ return util::Error{_("Error: Wallet does not exist")};`
	`4412`	`+ }`
`4410`	`4413`	`if (!IsBDBFile(BDBDataFile(*wallet_path))) {`
`4411`	`4414`	`return util::Error{_("Error: This wallet is already a descriptor wallet")};`
`4412`	`4415`	`}`