From af4d23178b420f46196fbace2176ce1fe94ed9cd Mon Sep 17 00:00:00 2001 From: Ava Chow Date: Mon, 10 Jun 2024 16:52:46 -0400 Subject: [PATCH] test: Add combinerawtransaction test to rpc_createmultisig The only coverage of combinerawtransaction is in a legacy wallet only test. So also use it in rpc_createmultisig so that this RPC remains tested after the legacy wallet is removed. --- test/functional/rpc_createmultisig.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/functional/rpc_createmultisig.py b/test/functional/rpc_createmultisig.py index d95820bbf876fb..3f3d4667f854d0 100755 --- a/test/functional/rpc_createmultisig.py +++ b/test/functional/rpc_createmultisig.py @@ -194,10 +194,12 @@ def do_multisig(self, nkeys, nsigs, output_type, wallet_multi): assert_raises_rpc_error(-8, "redeemScript/witnessScript does not match scriptPubKey", node2.signrawtransactionwithkey, rawtx, priv_keys[0:nsigs-1], [prevtx_err]) rawtx2 = node2.signrawtransactionwithkey(rawtx, priv_keys[0:nsigs - 1], prevtxs) - rawtx3 = node2.signrawtransactionwithkey(rawtx2["hex"], [priv_keys[-1]], prevtxs) - assert rawtx3['complete'] + assert_equal(rawtx2["complete"], False) + rawtx3 = node2.signrawtransactionwithkey(rawtx, [priv_keys[-1]], prevtxs) + assert_equal(rawtx3["complete"], False) + combined_rawtx = node2.combinerawtransaction([rawtx2["hex"], rawtx3["hex"]]) - tx = node0.sendrawtransaction(rawtx3["hex"], 0) + tx = node0.sendrawtransaction(combined_rawtx, 0) blk = self.generate(node0, 1)[0] assert tx in node0.getblock(blk)["tx"]