Skip to content

Commit 5a8ffea

Browse files
committed
test: Add explicit onion bind to p2p_permissions
When the bind option is replaced in the bitcoin.conf, bitcoind will attempd to bind to the default tor listening port. If another bitcoind is running that is already bound to that port, the bind will fail which, since bitcoin#22729, causes the test to fail.
1 parent d4b5553 commit 5a8ffea

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/functional/p2p_permissions.py

+3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
from test_framework.test_node import ErrorMatch
1515
from test_framework.test_framework import BitcoinTestFramework
1616
from test_framework.util import (
17+
append_config,
1718
assert_equal,
1819
p2p_port,
20+
tor_port,
1921
)
2022
from test_framework.wallet import MiniWallet
2123

@@ -57,6 +59,7 @@ def run_test(self):
5759
# by modifying the configuration file.
5860
ip_port = "127.0.0.1:{}".format(p2p_port(1))
5961
self.nodes[1].replace_in_config([("bind=127.0.0.1", "whitebind=bloomfilter,forcerelay@" + ip_port)])
62+
append_config(self.nodes[1].datadir_path, [f"bind=127.0.0.1:{tor_port(self.nodes[1].index)}=onion"])
6063
self.checkpermission(
6164
6265
# Check parameter interaction forcerelay should activate relay

0 commit comments

Comments
 (0)