Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: verify no dependencies are locally linked #11

Open
callumlocke opened this issue Oct 31, 2018 · 0 comments
Open

Suggestion: verify no dependencies are locally linked #11

callumlocke opened this issue Oct 31, 2018 · 0 comments

Comments

@callumlocke
Copy link

A problem I often have is I'm working on two packages, e.g. my-library and my-cli, and the latter depends on the former. (Doesn't have to be a CLI, this is just for illustration.) In this situation, it's common to do npm link my-library from my-cli during development. But then you might forget that this dependency is linked locally, and you think my-cli is all ready to publish (automated and manual testing seems to show it's all working nicely), so you publish it... But then it turns out the published version doesn't work, because you forgot to unlink, bump and republish the library, and then update the dependency for real in my-cli.

So it might be useful to add a check that prevents you publishing the package if any of its direct dependencies are local symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants