-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodebaseResource does not have all the features of commoncode Resource model #1585
Comments
I will open a PR to support |
AyanSinhaMahapatra
added a commit
that referenced
this issue
Feb 20, 2025
Adds methods in CodebaseResource objects to navigate from an archive to their corresponding extracted directory and vice versa. This is added to match the functions in commoncode.resource.Resource so these functions work in the scancode.io context similarly to how they work in the scancode-toolkit context. Reference: #1585 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
tdruez
pushed a commit
that referenced
this issue
Feb 20, 2025
Adds methods in CodebaseResource objects to navigate from an archive to their corresponding extracted directory and vice versa. This is added to match the functions in commoncode.resource.Resource so these functions work in the scancode.io context similarly to how they work in the scancode-toolkit context. Reference: #1585 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra Can this be closed following the merged of #1588 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to a need of maintaining a Codebase/Resource model to traverse and support all the scancode-toolkit functions we have two similar models with same functions to integrate scancode-toolkit in SCIO:
CodebaseResource
model mirrors thecommoncode.resource.Resource
modelProject
model has necessary functions with the same behavior from thecommoncode.resource.Codebase
modelBut the support is currently limited to the widely used functions in scancode-toolkit only, and not all the functions from the
commoncode.resource
models, and this causes failures when a new function is used on the scancode-toolkit side, which might not be supported on the scancode.io side yet.For example:
In aboutcode-org/scancode-toolkit#3983 we fixed some issues related to package resource assignment for jar manifests, and in the process we started using
commoncode.resource.Resource.extracted_to
from the suggestion at aboutcode-org/scancode-toolkit#3983 (comment), but this is not something that is supported in SCIO, so after this was released and used in SCIO, we had the following failure:So we need to do a review of all the functions present in
commoncode.resource
models which could be used in scancode-toolkit, and implement all of them here, and add tests to make sure they are all supported.The text was updated successfully, but these errors were encountered: