You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed in the DEV.to repo that pull requests are also being shown in the issues section: forem/forem#1816
While looking at the Github API docs I noticed that it mentions that pull requests are also being returned in the issues endpoint: https://developer.github.com/v3/issues/
Note: GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response. You can identify pull requests by the pull_request key.
Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id. To find out the pull request id, use the "List pull requests" endpoint.
I wasn't sure if this was a bug or maybe for some reason intended behaviour. Anyways if it is a bug this can easily be fixed by adjusting the filter in markdownIssues.js.
I can make a PR with the fix once this gets approved as a bug.
The text was updated successfully, but these errors were encountered:
Well, initially, it was an intended behavior or I can say I was forced to do it because I could not find a way at that time to make a difference.
I will check this PR out and will review it soon.
I noticed in the DEV.to repo that pull requests are also being shown in the issues section: forem/forem#1816
While looking at the Github API docs I noticed that it mentions that pull requests are also being returned in the issues endpoint: https://developer.github.com/v3/issues/
I wasn't sure if this was a bug or maybe for some reason intended behaviour. Anyways if it is a bug this can easily be fixed by adjusting the filter in
markdownIssues.js
.I can make a PR with the fix once this gets approved as a bug.
The text was updated successfully, but these errors were encountered: