Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloop puts the seams where the points are rather than spreading them uniformly over the length of the closed path #618

Open
cbmoore opened this issue Mar 24, 2023 · 1 comment
Milestone

Comments

@cbmoore
Copy link

cbmoore commented Mar 24, 2023

For a shape like a quarter circle, all but one of the points are along the arc so almost every seam is put along the arc. It would preferable (from a functionality standpoint) if the seams were evenly distributed over the length of the closed path rather than being distributed among the points that define it. If reloop is used after linesimplify, the effect is to make seams preferentially appear in regions of high curvature.

I acknowledge that this may be enough of an edge case to not be worth fixing for a general purpose tool like vpype and one could work around this by creating the path with points uniformly distributed along its length (independent of curvature) but I thought it was worth pointing out. You could also fix this by implementing something that does the opposite of linesimplify but I'm not sure I can think of any other use cases for such a thing.

@abey79 abey79 added this to the 2.0 milestone Apr 11, 2023
@abey79
Copy link
Owner

abey79 commented Apr 11, 2023

I will likely have to re-implement reloop for vpype 2. I'll keep this in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants