Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlay hints #146

Open
larshp opened this issue Jun 8, 2023 · 3 comments
Open

inlay hints #146

larshp opened this issue Jun 8, 2023 · 3 comments

Comments

@larshp
Copy link
Member

larshp commented Jun 8, 2023

inline DATA() types

@marcellourbani
Copy link
Contributor

I believe this should be done in abaplint core, inlay_hints.ts:
image

results:
image

@TheLazyHangman
Copy link

If an error in the inlay request is raised, every single user interaction with the editor, even just scrolling through the code, keeps triggering the notification and appending the log to the output:
image

Also, the option for turning off notifications doesn't seem to be having any effect (not sure if this is a VS or abaplint issue though).
image

Should I submit these as a separate issues?

@larshp
Copy link
Member Author

larshp commented Nov 12, 2024

any good way to reproduce? might just add a try/catch to ignore the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants