Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer builds with new RGBDS #1

Open
YoshiRulz opened this issue Jul 21, 2022 · 7 comments
Open

No longer builds with new RGBDS #1

YoshiRulz opened this issue Jul 21, 2022 · 7 comments

Comments

@YoshiRulz
Copy link

YoshiRulz commented Jul 21, 2022

When updating from 0.4.1 to 0.5.2, my automated builds stop working. derivation/before/diff/after

output of manual `make` call
cd src && rgbasm -E -Wno-truncation -Wextra -Wshift-amount -p 0xff -h -o ../rtc3test.o ../src/rom.asm
error: ../src/rom.asm(12) -> header.asm(17):
    syntax error, unexpected :
error: ../src/rom.asm(12) -> header.asm(23):
    syntax error, unexpected PRINT
error: ../src/rom.asm(12) -> header.asm(60):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(73):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(92):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(223):
    Invalid address $1e for RST
error: ../src/rom.asm(12) -> header.asm(228):
    Assertion failed
error: ../src/rom.asm(15) -> main.asm(4):
    Invalid address $16 for RST
error: ../src/rom.asm(15) -> main.asm(7):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(16):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(21):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(28):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(31):
    Invalid address $1e for RST
error: ../src/rom.asm(15) -> main.asm(100):
    Invalid address $16 for RST
error: ../src/rom.asm(15) -> main.asm(111):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(112):
    Invalid address $1e for RST
error: ../src/rom.asm(15) -> main.asm(130):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(138):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(145):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(170):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(175):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(187):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(195):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(9):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(101):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(114):
    syntax error, unexpected PRINT
error: ../src/rom.asm(27) -> basic.asm(103):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(109):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(113):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(118):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(149):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(167):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(182):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(64):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(117):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(142):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(193):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(242):
    Invalid address $2e for RST
error: Assembly aborted (38 errors)!
make: *** [Makefile:6: rtc3test.o] Error 1
@aaaaaa123456789
Copy link
Owner

Are you sure you're building the latest master?

@CasualPokePlayer
Copy link

The errors point to the Print function, which is probably conflicting with the newer PRINT command introduced in rgbds 0.5.0.

@aaaaaa123456789
Copy link
Owner

That's correct, but I was fairly certain I had fixed that... I'll check.

@CasualPokePlayer
Copy link

CasualPokePlayer commented Jul 21, 2022

The develop branch has it fixed it seems, but not master.

@aaaaaa123456789
Copy link
Owner

Gotcha. I'll post a new version later. Thanks!

@YoshiRulz
Copy link
Author

Bump—should I just switch to the develop branch? Does the resulting rom function the same?

@aaaaaa123456789
Copy link
Owner

The resulting ROM is just as functional. I'll try to remember to update to 0.6.0 this week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants