Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Trade Movie does not show the correct Species No. #15

Open
vulcandth opened this issue Nov 6, 2022 · 0 comments
Open

The Trade Movie does not show the correct Species No. #15

vulcandth opened this issue Nov 6, 2022 · 0 comments

Comments

@vulcandth
Copy link

The Trade movie does not show the correct species no. This is due to a needed Pokemon ID to Index conversion.

pokecrystal16/engine/movie/trade_animation.asm

Lines 896 to 897 in 677826d

ld de, wPlayerTrademonSpecies
call TrademonStats_PrintSpeciesNumber

pokecrystal16/engine/movie/trade_animation.asm

Lines 915 to 916 in 677826d

call TrademonStats_PrintSpeciesNumber
ld de, wOTTrademonSpeciesName

pokecrystal16/engine/movie/trade_animation.asm

Lines 973 to 978 in 677826d

TrademonStats_PrintSpeciesNumber:
hlcoord 10, 0
lb bc, PRINTNUM_LEADINGZEROS | 1, 3
call PrintNum
ld [hl], " "
ret

This is fixed in my rebase: vulcandth/pokecrystal16@5f6518b
astraldaughter pushed a commit to astraldaughter/pokecrystal16 that referenced this issue Mar 8, 2023
@vulcandth @aaaaaa123456789
QoL aaaaaa123456789#15: break link between animation frames bank and …
8970aa4 
…national dex ID

Co-Authored-By: aaaaaa123456789 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vulcandth