Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing custom height and width for validation resolutions #55

Open
a-r-r-o-w opened this issue Oct 19, 2024 · 1 comment
Open

Comments

@a-r-r-o-w
Copy link
Owner

When doing multi-resolution/frame training, validation only occurs for 49 x 720 x 480 videos. Since we support multiple prompts (--validation_prompts) and images as validation inputs (--validation_images) by making use of the --validation_prompt_separator, I think it also makes sense to support multiple resolutions via a --validation_resolutions parameter.

@zRzRzRzRzRzRzR @sayakpaul

@sayakpaul
Copy link
Collaborator

Yeah not a bad idea but the logic could get messy if I am envisioning it correctly. Better could be add a small note saying something like "since this trained using multiple resolutions, be sure to test it on multiple resolutions to confirm effectiveness."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants