Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Live hotnesses may not be loaded correctly #128

Open
YunzheZJU opened this issue Jan 24, 2022 · 0 comments
Open

[BUG] Live hotnesses may not be loaded correctly #128

YunzheZJU opened this issue Jan 24, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@YunzheZJU
Copy link
Owner

YunzheZJU commented Jan 24, 2022

Describe the bug
When the popup is open and a current live is ended, a locally made fake ended live without hotnesses will be pushed into the ended lives list. If the ended live's real data has already been loaded into the ended lives list, it will be replaced by the fake one, because repeated live ids will be removed.

Expected behavior
The ended live with hotnesses should stay.

Additional context
Removing repeated live ids is a patch behavior for the case where a live may be reopened after ended. In that case, multiple fake ended live with the same id will be created which may affect the UI rendering.

I think this is an issue suitable for new contributors.

@YunzheZJU YunzheZJU added bug Something isn't working good first issue Good for newcomers labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant