revert to php7 as it does not work with 8 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
😜 |
|
Thanks for this fix ! Perhaps it must be first accept on testing branch... |
rodinux
added a commit
to rodinux/phpldapadmin_ynh
that referenced
this pull request
Mar 12, 2024
as explained on PR YunoHost-Apps#29
2 tasks
|
superseeded by #30 |
tituspijean
added a commit
that referenced
this pull request
May 6, 2024
commit f5dab6a Author: yunohost-bot <[email protected]> Date: Mon May 6 05:24:43 2024 +0000 Auto-update READMEs commit d37bd48 Merge: b0e57ff c37650c Author: tituspijean <[email protected]> Date: Mon May 6 07:24:39 2024 +0200 Merge pull request #30 from rodinux/patch-1 Update manifest.toml to fix php version commit c37650c Author: Robles Rodolphe <[email protected]> Date: Sat Apr 6 23:13:13 2024 +0200 Update manifest.toml fix revert to php7.4 commit 32b756c Author: Robles Rodolphe <[email protected]> Date: Tue Mar 12 11:47:57 2024 +0100 Update manifest.toml to fix php version as explained on PR #29
ericgaspar
added a commit
that referenced
this pull request
May 6, 2024
* Add badges * Upgrade to v.1.2.6.2 * Remove --phpversion * Small fixes * set permissions * Fix linter warnings * Set SVG badge * Fix linter * patch (#11) * Add templates (#13) * Add templates * Update manifest.json * Auto-update README * Update check_process * 1.2.6.3 (#16) * 1.2.6.3 * Upgrade (#18) * Upgrade * Auto-update README * Fix Co-authored-by: yunohost-bot <[email protected]> * Version 2 (#21) * v2 * Auto-update README * v2 * fix * Auto-update README * Create change_url * Update manifest.toml --------- Co-authored-by: yunohost-bot <[email protected]> * Auto-update README * Update config.php.example Close #20 * fix linter * Update manifest.toml * Auto-update README * cleaning * Update manifest.toml * Update manifest.toml * Auto-update README * Auto-update README * Fix * Update upgrade * Update manifest.toml * Auto-update README * Update manifest.toml * Auto-update README * fix * Update manifest.toml to fix php version as explained on PR #29 * Update manifest.toml fix revert to php7.4 * Auto-update READMEs * Create DESCRIPTION_fr.md * Auto-update READMEs --------- Co-authored-by: Yunohost-Bot <> Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: Tagada <[email protected]> Co-authored-by: Robles Rodolphe <[email protected]> Co-authored-by: tituspijean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
see leenooks/phpLDAPadmin#260
also fixes #28
Solution
revert to php7 as it does not work with 8
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)