Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] YubiKeyDevice.FindAll does not find YubiKey 5 NFC on common NFC-Reader #143

Open
1 task done
mrmorrandir opened this issue Aug 27, 2024 · 4 comments
Open
1 task done
Labels
awaiting yubico action When we've got the ball bug Something isn't working

Comments

@mrmorrandir
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When using a YubiKey 5 NFC on a ACR122U reader (ACS ACR122U PICC Interface 0) the SDK will not return any YubiKeyDevice on YubiKeyDevice.FindAll().

Tests with .\ykman.exe --reader 'ACS ACR122U PICC Interface 0' info will return correct info:
image

Smartcard Device is shown correctly under Win10 Hardware Manager:
image

Yubico Authenticator can access the YubiKey:
image
image

Expected Behavior

YubiKeyDevice.FindAll() should return device to work with.

Steps To Reproduce

No response

Version

1.10.0

Version

5.4.3

Anything else?

The SmartCardDeviceListener detects the reader and card correctly, but the ISmartCardDeviceExtensions.IsYubicoDevice(...) method will return false because the ProductAtrs.AllYubiKeys.Contains(device.Atr!) will return false, because the ISmartCardDevice.Atr (that is also returned by the SmartCardDevice.GetSmartCardDevices().FirstOrDefault()) is not in the list.

@mrmorrandir mrmorrandir added the bug Something isn't working label Aug 27, 2024
@DennisDyallo DennisDyallo added the awaiting reply When we are waiting for response from user label Sep 25, 2024
@DennisDyallo
Copy link
Collaborator

I have a HID Global OMNIKEY 5022 (Smart Card Reader 0) and NFC works as expected for me. Is this happening consistently? What value are you getting as device.Atr! ?

@mrmorrandir

@mrmorrandir
Copy link
Author

mrmorrandir commented Sep 29, 2024

Yes, this problem is constant and with two readers of the same type. Can't get the atr at the moment because a colleague is trying something else with the reader
So... I ordered the device you mentioned, waiting for the package now.
I'll give it a try and compare the results. Will provide info about it when I'm done.

Thanks a lot for your help

@mrmorrandir
Copy link
Author

Today I got the new reader "OMNIKEY 5022 CL" and could test some things:

  • Yubico.YubiKey 1.10.0 DOES NOT work with the OMNIKEY
  • Yubico.YubiKey 1.11.0 DOES work with the OMNIKEY
  • None of the Libraries work with the PLUSONIC ACS ACR122U reader (see the image for information on the device)

image
Image was taken in Yubico.YubiKey.DeviceExtensions.IsYubicoDevice(this ISmartCardDevice device) method.

The Atr of the reader is 3B-8D-80-01-80-73-C0-21-C0-57-59-75-62-69-4B-65-FF-7F

Maybe the Atr of the YubiKey is not passed through the reader... I don't know - seems a problem of the reader itself.
Maybe a 'whitelising' option of other known 'Atr' would be good - or an option to disable this filter-function.

What does the YubiKeyAuthenticator do that it works there with the PLUSONIC reader?

@DennisDyallo
Copy link
Collaborator

Sorry for the late response. I will bring this to the team and see what we can come up with. I might get back to you for further questions! Thanks

@DennisDyallo DennisDyallo added awaiting yubico action When we've got the ball and removed awaiting reply When we are waiting for response from user labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting yubico action When we've got the ball bug Something isn't working
Development

No branches or pull requests

4 participants
@DennisDyallo @mrmorrandir and others