From c48d2dcd4e71cf87f4265ac431f2753233b6e86d Mon Sep 17 00:00:00 2001 From: Dennis Dyallo Date: Thu, 8 Aug 2024 11:38:01 +0200 Subject: [PATCH 1/2] Update pull_request_template.md --- .github/pull_request_template.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3dfe4437..4033cd13 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,27 +1,26 @@ # Description +*Please include a summary of the change and which issue is fixed, as well as relevant motivation and context. Finally, list any dependencies that are required for this change if any.* -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - -Fixes # +Fixes: # ## Type of change -Please delete options that are not relevant. - +- [ ] Refactor (non-breaking change which improves code quality or performance) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update -# How has this been tested? +## How has this been tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration **Test configuration**: -* Firmware version: -* Yubikey model: +* OS version: *e.g. Windows 11* +* Firmware version: *e.g. 5.7.2* +* Yubikey model[^1]: -# Checklist: +## Checklist: - [ ] My code follows the [style guidelines](https://raw.githubusercontent.com/Yubico/Yubico.NET.SDK/043119ad1d19e0e6e66556c970a81d0c1aba36c8/CONTRIBUTING.md) of this project - [ ] I have performed a self-review of my own code @@ -31,3 +30,5 @@ Please describe the tests that you ran to verify your changes. Provide instructi - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes + +[^1]: See [Yubikey models](https://www.yubico.com/store/) (Multi-protocol, Security Key, FIPS, Bio, YubiHSM) From 0ad55b283c88d6ed03c4c9ae423640a544132cc9 Mon Sep 17 00:00:00 2001 From: Dennis Dyallo Date: Thu, 8 Aug 2024 11:40:24 +0200 Subject: [PATCH 2/2] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4033cd13..5cd739a8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -31,4 +31,4 @@ Please describe the tests that you ran to verify your changes. Provide instructi - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes -[^1]: See [Yubikey models](https://www.yubico.com/store/) (Multi-protocol, Security Key, FIPS, Bio, YubiHSM) +[^1]: See [Yubikey models](https://www.yubico.com/products/) (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS)