Skip to content

Commit

Permalink
Merge branch 'develop' into dennisdyallo/logging
Browse files Browse the repository at this point in the history
  • Loading branch information
DennisDyallo authored Aug 12, 2024
2 parents 53e1df6 + 0ad55b2 commit 72f4eaf
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
# Description
*Please include a summary of the change and which issue is fixed, as well as relevant motivation and context. Finally, list any dependencies that are required for this change if any.*

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # <link to issue(s)>
Fixes: # <link to issue(s)>

## Type of change

Please delete options that are not relevant.

- [ ] Refactor (non-breaking change which improves code quality or performance)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

# How has this been tested?
## How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

**Test configuration**:
* Firmware version:
* Yubikey model:
* OS version: *e.g. Windows 11*
* Firmware version: *e.g. 5.7.2*
* Yubikey model[^1]:

# Checklist:
## Checklist:

- [ ] My code follows the [style guidelines](https://raw.githubusercontent.com/Yubico/Yubico.NET.SDK/043119ad1d19e0e6e66556c970a81d0c1aba36c8/CONTRIBUTING.md) of this project
- [ ] I have performed a self-review of my own code
Expand All @@ -31,3 +30,5 @@ Please describe the tests that you ran to verify your changes. Provide instructi
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

[^1]: See [Yubikey models](https://www.yubico.com/products/) (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS)

0 comments on commit 72f4eaf

Please sign in to comment.