Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the age in meta tag descriptions #116

Merged

Conversation

Keerthivardhan1
Copy link
Contributor

@Keerthivardhan1 Keerthivardhan1 commented Oct 22, 2022

Purpose

hear the issue is to change the age in the index.html files
The purpose of this Pull Request is to fix #76

Goals

As per the issue the goal is to update The age in the light/index.html file Facebook OG meta tag description's age 13 years old to 14 years old.
And The age in the Facebook OG meta tag description's age in index.html file is 1 years old change it to 14 years old

Approach

step1: clone the repo
step2: read README file and understand code structure of the project .
step3: update the age from 13 to 14 in light/index.html file Facebook OG meta tag.
step4:change the age in Facebook OG meta tag description's age in index.html file from 1 years old to 14 years old.
step4: add and commit the changes and push your branch.

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Chrome
Version 106.0.5249.119 (Official Build) (64-bit)

Learning

by understanding the project I learnt how to structure our code and divide in to categories

@Keerthivardhan1 Keerthivardhan1 changed the title Changed font weight Updated the age in meta tag descriptions Oct 22, 2022
@YoshithaRathnayake YoshithaRathnayake changed the title Updated the age in meta tag descriptions Update the age in meta tag descriptions Oct 22, 2022
light/index.html Outdated Show resolved Hide resolved
light/index.html Outdated Show resolved Hide resolved
@YoshithaRathnayake YoshithaRathnayake added good first issue Good for newcomers hacktoberfest-accepted For #Hacktoberfest that are counted as valid labels Oct 22, 2022
Copy link
Owner

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job !
Thank You @Keerthivardhan1

@YoshithaRathnayake YoshithaRathnayake merged commit 3380d7d into YoshithaRathnayake:main Oct 22, 2022
@Keerthivardhan1
Copy link
Contributor Author

Thank you @YoshithaRathnayake
I am new to git and githhub thanks for barring with me.

@YoshithaRathnayake
Copy link
Owner

Thank you @YoshithaRathnayake I am new to git and githhub thanks for barring with me.

Any time and you also did well at this issue @Keerthivardhan1

@YoshithaRathnayake
Copy link
Owner

Thank you @YoshithaRathnayake I am new to git and githhub thanks for barring with me.

Hope you will contribute more in my sites @Keerthivardhan1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest-accepted For #Hacktoberfest that are counted as valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change my age to 14 in the meta tag descriptions
2 participants