name updated in contact section #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshithaRathnayake
requested changes
Oct 15, 2022
dark/index.html
Outdated
| </section> | ||
|
|
||
| <!-- Contact Section --> | ||
|
|
||
| <section id="contact-section"> | ||
| <h1>CONTACT ME</h1> | ||
| <h3>CONTACT <span class="text-info">ME</span></h3> | ||
| <p class="about-text">Name: Yoshitha Rathnayake |
There was a problem hiding this comment.
Align them correctly because the sentence is in the top of the contact section topic
|
Ok
…On Sat, Oct 15, 2022, 12:06 YOSHITHA RATHNAYAKE ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In dark/index.html
<#103 (comment)>
:
> </section>
<!-- Contact Section -->
<section id="contact-section">
<h1>CONTACT ME</h1>
<h3>CONTACT <span class="text-info">ME</span></h3>
+ <p class="about-text">Name: Yoshitha Rathnayake
Align them correctly because the sentence is in the top of the contact
section topic
—
Reply to this email directly, view it on GitHub
<#103 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQSAWBG7TXTJLJCJCKTSWRLWDJGHNANCNFSM6AAAAAARFNBSNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
YoshithaRathnayake
requested changes
Oct 15, 2022
dark/index.html
Outdated
| </section> | ||
|
|
||
| <!-- Contact Section --> | ||
|
|
||
| <section id="contact-section"> | ||
| <h1>CONTACT ME</h1> | ||
| <h3>CONTACT <span class="text-info">ME</span></h3> | ||
| <p class="about-text">Name: Yoshitha Rathnayake | ||
| Location: Srilanka |
There was a problem hiding this comment.
Remove the Location : Srilanka
YoshithaRathnayake
requested changes
Oct 15, 2022
| <p class="contact-text"> | ||
| 📚 Education : St. Anthony's College, Kandy | ||
| </p> | ||
| <p class="about-text" text-align: center>Name: Yoshitha Rathnayake</p> |
There was a problem hiding this comment.
Some early changes also have been commited. Remove them also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this Pull Request is to fix #87
Goals
Added names to the contact section using text and font style.
Approach
Use text to add the name in the contact section
Preview Link
https://pr-103-NEW-YOSHITHA-WEBSITE.surge.sh
Checklist