Skip to content

Commit

Permalink
Can we build all maintained images as multi-arch?
Browse files Browse the repository at this point in the history
  • Loading branch information
solsson committed May 25, 2024
1 parent 09f7d1f commit 1f60483
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 8 deletions.
44 changes: 44 additions & 0 deletions .github/workflows/images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,50 @@ jobs:
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
-
name: Build and push headless-chrome latest
uses: docker/build-push-action@v5
env:
SOURCE_DATE_EPOCH: 0
with:
context: headless-chrome
tags: |
ghcr.io/yolean/headless-chrome:latest
ghcr.io/yolean/headless-chrome:${{ github.sha }}
platforms: linux/amd64,linux/arm64/v8
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
build-contexts: |
yolean/docker-base=docker-image://ghcr.io/yolean/docker-base
-
name: Build and push git-http-readonly latest
uses: docker/build-push-action@v5
env:
SOURCE_DATE_EPOCH: 0
with:
context: git-http-readonly
tags: |
ghcr.io/yolean/git-http-readonly:latest
ghcr.io/yolean/git-http-readonly:${{ github.sha }}
platforms: linux/amd64,linux/arm64/v8
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
-
name: Build and push runtime-quarkus latest
uses: docker/build-push-action@v5
env:
SOURCE_DATE_EPOCH: 0
with:
context: runtime-quarkus
tags: |
ghcr.io/yolean/runtime-quarkus:latest
ghcr.io/yolean/runtime-quarkus:${{ github.sha }}
platforms: linux/amd64,linux/arm64/v8
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
-
name: Build and push java root
uses: docker/build-push-action@v5
Expand Down
2 changes: 1 addition & 1 deletion git-http-readonly/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM httpd:2.4.58-bookworm@sha256:ba846154ade27292d216cce2d21f1c7e589f3b66a4a643bff0cdd348efd17aa3
FROM --platform=$TARGETPLATFORM httpd:2.4.58-bookworm@sha256:ba846154ade27292d216cce2d21f1c7e589f3b66a4a643bff0cdd348efd17aa3

RUN set -ex; \
export DEBIAN_FRONTEND=noninteractive; \
Expand Down
10 changes: 3 additions & 7 deletions test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ toil-network
node-distroless
blobs
headless-chrome
git-http-readonly
runtime-quarkus
"

MULTIARCH_TONONROOT="
Expand All @@ -44,11 +46,9 @@ runtime-quarkus-dev
toil-storage
"

AMD64ONLY="
runtime-quarkus
DEPRECATED="
runtime-quarkus-deno
runtime-deno
git-http-readonly
"

BEGIN=" ### build steps below are generated ###"
Expand Down Expand Up @@ -104,10 +104,6 @@ for CONTEXT in $MULTIARCH_TONONROOT; do
add_dependencies "to-nonroot/$CONTEXT" >> $ACTIONS
done
for CONTEXT in $AMD64ONLY; do
echo "# TODO does $CONTEXT really need to be amd64-only?" >&2
done
cp $ACTIONS $CURRENT
GIT_STATUS=$(git status --untracked-files=no --porcelain=v2)
[ -z "$GIT_STATUS" ] && echo "Done, no local diff" || echo "Done, with local diff"

0 comments on commit 1f60483

Please sign in to comment.