-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loading #26
Comments
This Particular scenario is happening whenever there is no legacy tables ( Expenses and loans ) in the firebase database. New Table names - ExpenseTable , LoanTable Need to avoid migration steps for new Databases created by new users. |
@YogeshPrasanna , @Abhijeetm96 What is the method to clear this issue. please apologise if my question is silly. Thanks in advance |
we'll have to check whether the legacy tables exists in the database , if they dont exist then we sould not make a request to those tables for migration. Here we are basically checking if the new tables have no records , we are trying to get the data from the legacy tables and put in here , this is what is causing infinite loading ,once you store values in the new DB this issue is solved , but for a new user who just lands in to the application , this needs to be handled . i'll Look into this in some time |
Hi Yogesh. any updates on the issue
…________________________________
From: Yogesh <[email protected]>
Sent: 03 July 2019 08:01
To: YogeshPrasanna/expense-manager-react
Cc: Rahulkasyap; Comment
Subject: Re: [YogeshPrasanna/expense-manager-react] Infinite loading (#26)
we'll have to check whether the legacy tables exists in the database , if they dont exist then we sould not make a request to those tables for migration.
Here we are basically checking if the new tables have no reacords , we are trying to get the data from the legacy tables and put in here , this is what is causing infinite loading ,once you store values in the new DB this issue is solved , but for a new user who just lands in to the application , this needs to be handled . i'll Look into this in some time
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#26?email_source=notifications&email_token=AMPHNQZBABB2SYVJR7Y2UCTP5QFQJA5CNFSM4H4LR7NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDCLOY#issuecomment-507913659>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMPHNQ6FLYMRA7X7SMO77EDP5QFQJANCNFSM4H4LR7NA>.
|
There's some work to do for that , for now I'll give a temporary fix to show the loan button in loan page . |
Hi @YogeshPrasanna
The loan page is in infinite loading state. Even the insert (+) button is missing. However didn't find any such issue with your demo site.
The text was updated successfully, but these errors were encountered: