Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loading #26

Open
Abhijeetm96 opened this issue Jun 30, 2019 · 6 comments
Open

Infinite loading #26

Abhijeetm96 opened this issue Jun 30, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Abhijeetm96
Copy link

Abhijeetm96 commented Jun 30, 2019

Hi @YogeshPrasanna

The loan page is in infinite loading state. Even the insert (+) button is missing. However didn't find any such issue with your demo site.

image

@Abhijeetm96
Copy link
Author

I figured out the infinite loading is because there is no data available. The main concern is with the (+) button.

image

This is what i got when i deleted every records from the expense table. So I assume the same would be the case with loan page too.

After inserting data
image

@YogeshPrasanna YogeshPrasanna added the bug Something isn't working label Jun 30, 2019
@YogeshPrasanna
Copy link
Owner

YogeshPrasanna commented Jul 1, 2019

This Particular scenario is happening whenever there is no legacy tables ( Expenses and loans ) in the firebase database.

New Table names - ExpenseTable , LoanTable

Need to avoid migration steps for new Databases created by new users.

@Rahulkasyap
Copy link

@YogeshPrasanna , @Abhijeetm96

What is the method to clear this issue. please apologise if my question is silly.

Thanks in advance

@YogeshPrasanna
Copy link
Owner

YogeshPrasanna commented Jul 3, 2019

we'll have to check whether the legacy tables exists in the database , if they dont exist then we sould not make a request to those tables for migration.

Here we are basically checking if the new tables have no records , we are trying to get the data from the legacy tables and put in here , this is what is causing infinite loading ,once you store values in the new DB this issue is solved , but for a new user who just lands in to the application , this needs to be handled . i'll Look into this in some time

@YogeshPrasanna YogeshPrasanna self-assigned this Jul 3, 2019
@Rahulkasyap
Copy link

Rahulkasyap commented Jul 13, 2019 via email

@YogeshPrasanna
Copy link
Owner

There's some work to do for that , for now I'll give a temporary fix to show the loan button in loan page .
I'll check in the code tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants