Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to Open Menu and Store #24

Open
YodasWs opened this issue Apr 13, 2015 · 4 comments
Open

Fail to Open Menu and Store #24

YodasWs opened this issue Apr 13, 2015 · 4 comments
Assignees
@YodasWs
Labels
bug Firefox Windows Phone

Comments

@YodasWs
Copy link
Owner

YodasWs commented Apr 13, 2015

Is IE claiming to be Android? Or is my tapComplete reset failing?

No error is being thrown to my logging server...
@YodasWs YodasWs self-assigned this Apr 13, 2015
@YodasWs
Copy link
Owner Author

YodasWs commented Apr 13, 2015

It could be the separate, first callback that cancels default click behavior on my links... Is IE then not calling the other callback functions?

@YodasWs YodasWs changed the title Fail to Open Menu and Store in Windows Phone IE Fail to Open Menu and Store Apr 26, 2015
@YodasWs
Copy link
Owner Author

YodasWs commented Apr 26, 2015

And I've been told that this is a problem in Firefox.

YodasWs added a commit that referenced this issue Apr 27, 2015
@YodasWs
Test reverting double-tap prevention
d8e7561 
For #24
YodasWs added a commit that referenced this issue Apr 27, 2015
@YodasWs
Remove double-tap prevention
8c0ffce 
It doesn't appear to have been necessary for Android and may now be the cause of my problems in #24
@YodasWs
Copy link
Owner Author

YodasWs commented Apr 27, 2015

I'm thinking it is what I suggested two weeks ago, that the problem is caused by this line:

Z(document).on('tap click','a[href^="#"]',false)

and I'm sure that will mean that I'll need to revert the two commits mentioned above...

It would be helpful to confirm, though, with some additional error logging...

YodasWs added a commit that referenced this issue Apr 29, 2015
@YodasWs
Prevent default link action
5c97965 
instead of having Zepto.js additionally stopping propagation

For #24
YodasWs added a commit that referenced this issue Jun 23, 2015
@YodasWs
Allow click/tap on child elements
199101b 
For #24, #50
@YodasWs
Copy link
Owner Author

YodasWs commented Jan 7, 2016

The problem is that both the tap and click events were being triggered when the user tapped somewhere, causing the function to be called twice, undoing what it had done. Hopefully fixed by 4285b03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YodasWs YodasWs

Labels
bug Firefox Windows Phone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YodasWs