Cleaning cache/pdf folder

[davide-alghi]

It would be useful to clean the cache/pdf folder: it's filled by 'Generate PDF file -> One PDF file' and by 'Send PDF WorkFlow task'.
For 'Send PDF WorkFlow task', it's not an easy job due to 'Execution schedule -> Specific date'.
The folder could get very heavy.

[mariuszkrzaczkowski]

That's why it exists

YetiForceCRM/modules/Vtiger/crons/Cache.php

Lines 15 to 38 in ef4e83d

	class Vtiger_Cache_Cron extends \App\CronHandler
	{
	/**
	* {@inheritdoc}
	*/
	public function process()
	{
	$time = strtotime('-30 day');
	$dirs = ['pdf', 'import', 'mail', 'session', 'vtlib', 'rss_cache', 'upload'];
	$exclusion = ['.htaccess', 'index.html'];
	foreach ($dirs as $dir) {
	foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator(ROOT_DIRECTORY . DIRECTORY_SEPARATOR . 'cache' . DIRECTORY_SEPARATOR . $dir, \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
	if ($item->isFile() && !\in_array($item->getBasename(), $exclusion) && $item->getMTime() < $time && $item->getATime() < $time) {
	unlink($item->getPathname());
	}
	}
	}
	foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator(\App\Fields\File::getTmpPath(), \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
	if ($item->isFile() && !\in_array($item->getBasename(), $exclusion) && $item->getMTime() < $time && $item->getATime() < $time) {
	unlink($item->getPathname());
	}
	}
	}
	}

[davide-alghi]

ah ok, I didn't know about it
but if I set a workflow running every day with a task sending a PDF (with "Send PDF" task), it'll work also after 30 days?

[davide-alghi]

I'm replying to myself ... yes it'll work :D

[mariuszkrzaczkowski]

I improved this mechanism, see clearing the cache from the CLI

CLI.mp4

[davide-alghi]

great 👍

[rskrzypczak]

If I am not mistaken, there should be no PDF files in this directory. All temporary files generated there should be deleted automatically when you downloaded the PDF or sent it by e-mail.

In older versions, the system did leave files in it, but currently it shouldn't.
If there are files left in this directory for the new pdfs, it means that something went wrong, e.g. the e-mail with pdf was not sent.

[davide-alghi]

yes @rskrzypczak,
when you send by email or download, temp files are deleted. As I wrote, temp files are kept with 'Generate PDF file -> One PDF file' and 'Send PDF WorkFlow task'.
Anyway ... I'll check better on last stable version.

[rskrzypczak]

I meant all the operations that generate the Pdf file, including the two that you mentioned.
If some functionality does not delete these temporary files, treat it as a bug.

P.S.
I checked it on the current development version and it seems fine.