Add test case that ensures that examples are triggering the desired rule #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 60 60
Lines 1891 1898 +7
Branches 121 121
=====================================
+ Hits 1891 1898 +7
Continue to review full report at Codecov.
|
sjaensch
approved these changes
Feb 14, 2020
macisamuele
deleted the
maci-add-test-to-ensure-that-tester-are-testing-the-correct-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #22 I felt like having examples is great.
But not being sure about the fact examples are still triggering the desired rule is not great.
In order to address this I've added a new test
test_ensure_that_examples_are_covering_the_correct_rulethat essentially runs the tool over the examples files and ensures that the correct reporting is thrown.