Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simple tool to create skeleton of new rules #26

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

macisamuele
Copy link
Collaborator

In the spirit of helping new contributors to get onboard and to help us creating new rules if needed I'm providing a tool that might help with the creation of a new rule.

The tool takes care of creating the skeleton files needed to implement the rules as well as for its documentation.

The tool is definitely not the most nice looking python code, but I thought that was OK-ish to have something more verbose that bootstraps a new rule.

@macisamuele macisamuele requested a review from sjaensch February 13, 2020 12:21
@macisamuele macisamuele added the enhancement New feature or request label Feb 13, 2020
@macisamuele macisamuele force-pushed the maci-tool-to-easily-create-rules branch 2 times, most recently from 7d7c71b to afc02fb Compare February 13, 2020 12:32
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          60     60           
  Lines        1898   1898           
  Branches      121    121           
=====================================
  Hits         1898   1898
Impacted Files Coverage Δ
swagger_spec_compatibility/rules/common.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe71f1...03a6284. Read the comment docs.

README.rst Outdated Show resolved Hide resolved
@macisamuele macisamuele force-pushed the maci-tool-to-easily-create-rules branch from afc02fb to b70715d Compare February 17, 2020 09:53
@macisamuele macisamuele force-pushed the maci-tool-to-easily-create-rules branch from b70715d to 03a6284 Compare February 17, 2020 09:57
@macisamuele macisamuele merged commit 13debf2 into Yelp:master Feb 18, 2020
@macisamuele macisamuele deleted the maci-tool-to-easily-create-rules branch February 18, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants