Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger operation IDs modified after protobuf version update #88

Open
sarthakn7 opened this issue Apr 13, 2020 · 1 comment
Open

Swagger operation IDs modified after protobuf version update #88

sarthakn7 opened this issue Apr 13, 2020 · 1 comment

Comments

@sarthakn7
Copy link
Contributor

sarthakn7 commented Apr 13, 2020

Due to grpc-ecosystem/grpc-gateway#1193, we have LuceneServer_ prepended to all operation IDs. The PR mentions that the maintainers will add a flag to go back to the previous behavior and we should update our protobuf dependency when that flag gets added.

Till then, we can run sed -i 's/LuceneServer_//g' luceneserver.swagger.json to get back the previous operation IDs. We can either run it manually or just add it to the generation step (risky if there is some other change in swagger generation and we replace something other than operation ID).

@johanbrandhorst
Copy link

Another option is to depend on the latest release - this change has not made it into a release yet. https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v1.14.3 does not change the format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants