Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of detected secrets in the end of the output in the pre-commit hooks #880

Open
1 of 2 tasks
AmineDjeghri opened this issue Sep 7, 2024 · 0 comments
Open
1 of 2 tasks

Add number of detected secrets in the end of the output in the pre-commit hooks #880

AmineDjeghri opened this issue Sep 7, 2024 · 0 comments
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. P2 Important. E.g. a new feature that we want to include in the next release. request The issue is a request for a new feature or plugin. triaged The issue has been reviewed but has not been solved yet.

Comments

@AmineDjeghri
Copy link

  • I'm submitting a ...

    • bug report
    • feature request

  • What is the current behavior?
    The current output of the detect-secrets pre-commit hook lists secrets found but does not provide the total number of detected secrets at the end of the output.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  • What is the expected behavior?
    The output should include a summary at the end that shows the total number of secrets detected in the pre-commit hook scan.

  • What is the motivation / use case for changing the behavior?
    Having the total count of detected secrets at the end of the output will provide better visibility to developers. It allows them to easily see how many secrets were found, without needing to manually count them.

  • Please tell us about your environment:

    • detect-secrets Version:
  -   repo: https://github.com/Yelp/detect-secrets
      rev: v1.5.0
      hooks:
        -   id: detect-secrets
  • Python Version: 3.11
  • OS Version: Ubuntu 22.04
@lorenzodb1 lorenzodb1 added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. good first issue The issue can be tackled by someone who has little to no knowledge about the project. triaged The issue has been reviewed but has not been solved yet. request The issue is a request for a new feature or plugin. P2 Important. E.g. a new feature that we want to include in the next release. labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. P2 Important. E.g. a new feature that we want to include in the next release. request The issue is a request for a new feature or plugin. triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorenzodb1 @AmineDjeghri