Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: don't treat all JWT as secrets/credentials #688

Open
1 of 2 tasks
spockz opened this issue Apr 26, 2023 · 0 comments
Open
1 of 2 tasks

Feature: don't treat all JWT as secrets/credentials #688

spockz opened this issue Apr 26, 2023 · 0 comments
Labels
false positives triaged The issue has been reviewed but has not been solved yet.

Comments

@spockz
Copy link

spockz commented Apr 26, 2023

  • I'm submitting a ...

    • bug report
    • feature request
  • What is the current behavior?

Any file containing something looking like a JWT (based on it has 2 dots, and the first two segments are base64encoded JSON) is reported as a secret/credential.

  • What is the expected behavior?

It should be possible to detect or configure the plugin to allow certain types of JWT.

  • What is the motivation / use case for changing the behavior?

We use JWT also for exchanging signed information and this is not secret data so these tokens are not secrets. However, our tooling is now generating many false positives which drowns the true positives.

  • Please tell us about your environment:
    • detect-secrets Version: 1.4.0
    • Python Version: 3.x
    • OS Version: Linux
    • File type (if applicable): JWT
@lorenzodb1 lorenzodb1 added the pending The issue still needs to be reviewed by one of the maintainers. label Nov 17, 2023
@lorenzodb1 lorenzodb1 added false positives triaged The issue has been reviewed but has not been solved yet. and removed pending The issue still needs to be reviewed by one of the maintainers. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positives triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Development

No branches or pull requests

2 participants