Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint configuration #12

Open
2 tasks
Yedidyar opened this issue Aug 29, 2023 · 3 comments · Fixed by #16
Open
2 tasks

Add eslint configuration #12

Yedidyar opened this issue Aug 29, 2023 · 3 comments · Fixed by #16
Labels
good first issue Good for newcomers

Comments

@Yedidyar
Copy link
Owner

Yedidyar commented Aug 29, 2023

you can see this article how to configure eslint in 2023

  • add it to the ci
  • add husky checks
@Yedidyar Yedidyar added the good first issue Good for newcomers label Aug 29, 2023
@jycouet
Copy link
Collaborator

jycouet commented Aug 30, 2023

FYI: Actually, I run my formater (of my project) after, to match all my rules.

@Yedidyar
Copy link
Owner Author

Linting is different then formatting 🤔
But it can be idea for a feature:
option that runs the formmater after the generation.

@Yedidyar Yedidyar linked a pull request Aug 30, 2023 that will close this issue
@Yedidyar Yedidyar reopened this Aug 31, 2023
@jycouet
Copy link
Collaborator

jycouet commented Dec 29, 2023

I think that you should update this issue as I see 2 concerns that are not linked:

1/ update the repo with ESLINT
I think that this is done (please no husky), I like a failing PR, but not things running on my machine.
I think that it's this issue and it can be closed.

2/ Adding the option to format code after generation
I did it here: https://www.kitql.dev/docs/tools/06_vite-plugin-kit-routes#side-notes with a post_update_run that will execute any cmd.
I think that it can be another issue. (I think that it has close to 0 value as remult-cli is a one shot generator, people can do this cmd by hand after)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants