PUSH/POP shift ss too much

[neldredge]

In the push/pop instructions, the value of ss is multiplied by 0x10 before passing to Address::calculate_from_offset:

8086-Emulator/src/lib/interpreter/interpreter.lalrpop

Lines 248 to 250 in 7d0fd42

	let ss = vm.arch.ss as usize*0x10;
	let sp = vm.arch.sp as usize;
	let base = Address::calculate_from_offset(ss,sp);

But the latter multiplies by 0x10 again:

8086-Emulator/src/lib/util/address.rs

Line 27 in 7d0fd42

make_valid_address(base.into() * 0x10 + offset.into())

So ss effectively gets shifted 8 bits instead of 4.

You can reproduce with

mov ax, 0x1000
mov ss, ax
mov sp, 0x20
mov bx, 0xdead
push bx

and note that address 0x0001e gets written instead of 0x1001e as it should.