Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rename fru-print.py to fru-print or support both #4

Open
lool opened this issue May 17, 2022 · 0 comments
Open

Please rename fru-print.py to fru-print or support both #4

lool opened this issue May 17, 2022 · 0 comments
Assignees

Comments

@lool
Copy link
Contributor

lool commented May 17, 2022

Hi,

Currently, image-update calls fru-print.py. In Xilinx/xmutil#2, I'm requesting to vendor fru-print into xmutil and to stop installing it as fru-print.py. Probably fru-print could even be removed from usr/bin entirely as it should really be called from xmutil.

In the mean time, it would be nice if image-update would support calling /usr/bin/fru-print or /usr/bin/fru-print.py as Ubuntu currently installs fru-print.py as /usr/bin/fru-print. The patch that we use in Ubuntu is quite trivial, but it's not suitable for inclusion until fru-print.py is renamed to fru-print in petalinux:

===================================================================
--- xmutil-2022.1.orig/image-update/image_update.c
+++ xmutil-2022.1/image-update/image_update.c
@@ -632,7 +632,7 @@ static int validate_board_string(void)
 	FILE *cmd;
 	char revision[10U] = {0U};
 
-	cmd = popen("fru-print.py -b som -f revision", "r");
+	cmd = popen("fru-print -b som -f revision", "r");
 	if (!cmd) {
 		printf("Unable to read Board revision from EEprom\n");
 		return ret;
@@ -644,7 +644,7 @@ static int validate_board_string(void)
 		ret = XST_SUCCESS;
 	} else {
 		printf("Unable to read Board revision from EEprom via ");
-		printf("fru-print.py utility\n");
+		printf("fru-print utility\n");
 	}
 	pclose(cmd);
 

Best
LM

@lool lool changed the title Please rename support fru-print and fru-print.py Please rename fru-print.py to fru-print or support both May 18, 2022
@bsvikram bsvikram closed this as completed Jun 7, 2022
@bsvikram bsvikram reopened this Jun 7, 2022
@bsvikram bsvikram self-assigned this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants