Replace even more GTK 1 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button for the drop down menu can now be focused by tab. GtkComboBoxText doesn't allow disabling focus on it. "Add Master" dialog now updates the selected protocol button based on the typed text rather than clicking the history as GtkComboBoxText doesn't have a separate event.
Statistics Country game list doesn't have a separator any more and "All Games" is not centered.
gtk_adjustment_new() returns GtkObject in GTK2 and GtkAdjustment in GTK3.
zturtleman
force-pushed
the
gtk2_update
branch
from
a23ba4b
to
48d97bd
Compare
|
The image loading and combining now uses GdkPixbuf. I think it's GTK3 compatible now (without Cairo after all). The game icons are restored in the game list and drop down menus now that they are in GdkPixbuf form. I'm not aware of any new issues. Though I may modify the commits as I deal with gtk_clist and gtk_ctree so the GTK3 build will link. |
|
I don't see any regression. I can merge this now and you can submit |
|
Yeah, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm continuing toward GTK 2 without deprecated features / GTK3. It's not as bad as I remembered and made it out to be in #234.
This PR is currently missing images in game lists and drop down menus as I haven't integrated my GdkPixbuf work from a year ago yet. [Now solved.]
Beyond that, still need to replace gtk_clist (179 code references), gtk_ctree (48 code references), and replace deprecated GTK2 image combining stuff with Cairo (gdk_gc_*/ gdk_draw_* 49 code references). [Image combining is solved.]