Skip to content

Commit a44afdd

Browse files
committed
fix(code): remove ".clone" from "if let" statement
fixes #130
1 parent 82ddae5 commit a44afdd

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/code.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ fn build_table_fns(
569569
// "Option::None" will never match anything, and "is_null" is required to be used, see https://docs.diesel.rs/master/diesel/expression_methods/trait.ExpressionMethods.html#method.eq
570570
format!(
571571
r##"
572-
if let Some(filter_{column_name}) = filter.{column_name}.clone() {{
572+
if let Some(filter_{column_name}) = filter.{column_name} {{
573573
query = if filter_{column_name}.is_some() {{
574574
query.filter({schema_path}{table_name}::{column_name}.eq(filter_{column_name}))
575575
}} else {{
@@ -580,7 +580,7 @@ fn build_table_fns(
580580
} else {
581581
format!(
582582
r##"
583-
if let Some(filter_{column_name}) = filter.{column_name}.clone() {{
583+
if let Some(filter_{column_name}) = filter.{column_name} {{
584584
query = query.filter({schema_path}{table_name}::{column_name}.eq(filter_{column_name}));
585585
}}"##
586586
)

test/advanced_queries/models/todos/generated.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -131,28 +131,28 @@ impl Todos {
131131
) -> crate::schema::todos::BoxedQuery<'a, diesel::pg::Pg> {
132132
let mut query = crate::schema::todos::table.into_boxed();
133133

134-
if let Some(filter_id) = filter.id.clone() {
134+
if let Some(filter_id) = filter.id {
135135
query = query.filter(crate::schema::todos::id.eq(filter_id));
136136
}
137-
if let Some(filter_text) = filter.text.clone() {
137+
if let Some(filter_text) = filter.text {
138138
query = query.filter(crate::schema::todos::text.eq(filter_text));
139139
}
140-
if let Some(filter_completed) = filter.completed.clone() {
140+
if let Some(filter_completed) = filter.completed {
141141
query = query.filter(crate::schema::todos::completed.eq(filter_completed));
142142
}
143-
if let Some(filter_type_) = filter.type_.clone() {
143+
if let Some(filter_type_) = filter.type_ {
144144
query = query.filter(crate::schema::todos::type_.eq(filter_type_));
145145
}
146-
if let Some(filter_smallint) = filter.smallint.clone() {
146+
if let Some(filter_smallint) = filter.smallint {
147147
query = query.filter(crate::schema::todos::smallint.eq(filter_smallint));
148148
}
149-
if let Some(filter_bigint) = filter.bigint.clone() {
149+
if let Some(filter_bigint) = filter.bigint {
150150
query = query.filter(crate::schema::todos::bigint.eq(filter_bigint));
151151
}
152-
if let Some(filter_created_at) = filter.created_at.clone() {
152+
if let Some(filter_created_at) = filter.created_at {
153153
query = query.filter(crate::schema::todos::created_at.eq(filter_created_at));
154154
}
155-
if let Some(filter_updated_at) = filter.updated_at.clone() {
155+
if let Some(filter_updated_at) = filter.updated_at {
156156
query = query.filter(crate::schema::todos::updated_at.eq(filter_updated_at));
157157
}
158158

0 commit comments

Comments
 (0)