Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

dsnvm_handle_receive_coherence #7

Open
liweiguang199609 opened this issue Jul 4, 2019 · 2 comments
Open

dsnvm_handle_receive_coherence #7

liweiguang199609 opened this issue Jul 4, 2019 · 2 comments

Comments

@liweiguang199609
Copy link

The "dsnvm_handle_receive_coherence" function is used to process the consistency command that the DN receives from ON in the second stage of the MRMW process, but there is no mention of local dirty page that has been modified. Is that right ?
If the page has been modified locally, direct fetch operation will overwrite the page rather than allocating a new physical page.

@lastweek
Copy link
Contributor

lastweek commented Jul 6, 2019

Hi @liweiguang199609,

Local dirty pages should be checked by scan_xact_pages()https://github.com/WukLab/Hotpot/blob/master/hotpot/xact.c#L2512, which will lookup PTE and do necessary actions. (The code was written long time ago, I only have vague memory about the details now.

@liweiguang199609
Copy link
Author

Hi @liweiguang199609,

Local dirty pages should be checked by scan_xact_pages()https://github.com/WukLab/Hotpot/blob/master/hotpot/xact.c#L2512, which will lookup PTE and do necessary actions. (The code was written long time ago, I only have vague memory about the details now.

Hi lastweek,

Yeah, I looked at the function carefully, but I still didn't see the part of the operation mentioned in the paper.For example, if the xact being committed is version 1, and the dirty page in the DN is based on version 0 instead of version 1. It seems wrong to reserve the local dirty page , because the dirty page is based on the version of the old page.
96@XJ`9G4)7JL(YUEFM1CQN

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants